From 46cbae088efe551d77da141899a761c5645a623e Mon Sep 17 00:00:00 2001
From: Kohya S <ykumeykume@gmail.com>
Date: Sun, 23 Apr 2023 19:15:48 +0900
Subject: [PATCH 1/2] fix to log with logging_dir without log_with

---
 library/train_util.py | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/library/train_util.py b/library/train_util.py
index 091e04f6..40119c77 100644
--- a/library/train_util.py
+++ b/library/train_util.py
@@ -2758,7 +2758,10 @@ def prepare_accelerator(args: argparse.Namespace):
         logging_dir = args.logging_dir + "/" + log_prefix + time.strftime("%Y%m%d%H%M%S", time.localtime())
 
     if args.log_with is None:
-        log_with = None
+        if logging_dir is not None:
+            log_with = "tensorboard"
+        else:
+            log_with = None
     else:
         log_with = args.log_with
         if log_with in ["tensorboard", "all"]:

From 05c57b9c7bff7413e3e1cea1ea106c88ddb4e690 Mon Sep 17 00:00:00 2001
From: Kohya S <ykumeykume@gmail.com>
Date: Sun, 23 Apr 2023 19:18:04 +0900
Subject: [PATCH 2/2] update readme

---
 README.md | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/README.md b/README.md
index fe578cf3..eeaddb7a 100644
--- a/README.md
+++ b/README.md
@@ -127,6 +127,11 @@ The majority of scripts is licensed under ASL 2.0 (including codes from Diffuser
 
 ## Change History
 
+### 23 Apr. 2023, 2023/4/23:
+
+- Fixed to log to TensorBoard when `--logging_dir` is specified and `--log_with` is not specified.
+- `--logging_dir`を指定し`--log_with`を指定しない場合に、以前と同様にTensorBoardへログ出力するよう修正しました。
+
 ### 22 Apr. 2023, 2023/4/22:
 
 - Added support for logging to wandb. Please refer to [PR #428](https://github.com/kohya-ss/sd-scripts/pull/428). Thank you p1atdev!