Refactoring: auth tests pass

src/crud/users.py

@@ -8,9 +8,9 @@ from src.schemas.users import UserCreate
 pwd_context = CryptContext(schemes=["bcrypt"], deprecated="auto")
 
 
-def check_empty_fields(username: str, password: str, avatar: str):
+def check_empty_fields(username: str, password: str, avatar_index: int):
     "Checks if any user fields are empty"
-    if len(avatar) == 0:
+    if  avatar_index < 0:
         raise HTTPException(status_code=400, detail="No avatar was provided")
     if len(username) == 0:
         raise HTTPException(status_code=400, detail="No username was provided")
@@ -20,7 +20,7 @@ def check_empty_fields(username: str, password: str, avatar: str):
 
 def patch_user(db: Session, username: str, user: UserCreate):
     """Changes the username and/or the password of a User"""
-    check_empty_fields(user.username, user.password, user.avatar)
+    check_empty_fields(user.username, user.password, user.avatar_index)
     db_user = get_user_by_username(db, username)
     potential_duplicate = get_user_by_username(db, user.username)
     if potential_duplicate:
@@ -28,7 +28,7 @@ def patch_user(db: Session, username: str, user: UserCreate):
             raise HTTPException(status_code=400, detail="Username already registered")
     db_user.username = user.username
     db_user.hashed_password = pwd_context.hash(user.password)
-    db_user.avatar = user.avatar
+    db_user.avatar_index = user.avatar_index
     db.commit()