WeSign/unity-application
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 6 Wiki Activity

Draft: fixed aspect (kinda) #31

Closed
jrcoudro wants to merge 0 commits from WES-50-Course-Aspect-Fix into development
pull from: WES-50-Course-Aspect-Fix
merge into: WeSign:development
Conversation 16 Commits - Files Changed -
jrcoudro commented 2023-03-11 16:33:18 +00:00 (Migrated from gitlab.ilabt.imec.be)
Copy Link

Description

Changed the UI of the course-screen. The image, video and webcam should all have correct aspect ratios now.
The image and video stay within a predefined box, this behaviour has not been achieved for the webcam yet though.

Aspect

Testing Instructions

Please provide instructions on how the code reviewers can test your changes:

Not much to test, since it's purely a UI change. You can check the course-scene and decide if it looks acceptable.

Known bugs or issues

The webcam aspect-change is not where I want it to be. It does not stay within a predefined box, meaning it can grow taller or wider than initially wanted.

Checklist

  • I have filled in this template.
  • I have tested my changes thoroughly.
  • [~] I have added appropriate unit tests.
  • I have updated the user documentation as necessary.
  • Code reviewed by 2 people.

Closes WES-50

## Description Changed the UI of the course-screen. The image, video and webcam should all have correct aspect ratios now. The image and video stay within a predefined box, this behaviour has not been achieved for the webcam yet though. ![Aspect](/uploads/f91c436543edbb9b6ec78753f45c5829/Aspect.png) ## Testing Instructions Please provide instructions on how the code reviewers can test your changes: Not much to test, since it's purely a UI change. You can check the course-scene and decide if it looks acceptable. ## Known bugs or issues The webcam aspect-change is not where I want it to be. It does not stay within a predefined box, meaning it can grow taller or wider than initially wanted. ## Checklist - [x] I have filled in this template. - [x] I have tested my changes thoroughly. - [~] I have added appropriate unit tests. - [x] I have updated the user documentation as necessary. - [x] Code reviewed by 2 people. Closes WES-50
jrcoudro commented 2023-03-11 16:34:09 +00:00 (Migrated from gitlab.ilabt.imec.be)
Copy Link

added 4 commits

  • 9770658a...c0a8cede - 3 commits from branch development
  • 2a5d10db - Merge branch 'development' into 'WES-50-Course-Aspect-Fix'

Compare with previous version

added 4 commits <ul><li>9770658a...c0a8cede - 3 commits from branch <code>development</code></li><li>2a5d10db - Merge branch &#39;development&#39; into &#39;WES-50-Course-Aspect-Fix&#39;</li></ul> [Compare with previous version](/wesign/unity-application/-/merge_requests/31/diffs?diff_id=29978&start_sha=9770658ab7d5a5233a47c017ab44acdd8807620d)
jrcoudro commented 2023-03-11 16:35:08 +00:00 (Migrated from gitlab.ilabt.imec.be)
Copy Link

requested review from @dvschuyl, @hvbreuge, @louadria, @jeldgees, @lvrossem, and @tihabils

requested review from @dvschuyl, @hvbreuge, @louadria, @jeldgees, @lvrossem, and @tihabils
jrcoudro commented 2023-03-11 16:35:49 +00:00 (Migrated from gitlab.ilabt.imec.be)
Copy Link

changed the description

changed the description
dvschuyl commented 2023-03-12 10:49:45 +00:00 (Migrated from gitlab.ilabt.imec.be)
Copy Link

Seems to work great!

I tested it on videos with an aspect ratio of 16:9, 9:16, 1:1, and 21:9 and they were all correctly scaled.

Seems to work great! I tested it on videos with an aspect ratio of 16:9, 9:16, 1:1, and 21:9 and they were all correctly scaled.
dvschuyl commented 2023-03-12 10:49:48 +00:00 (Migrated from gitlab.ilabt.imec.be)
Copy Link

approved this merge request

approved this merge request
lvrossem commented 2023-03-12 12:38:21 +00:00 (Migrated from gitlab.ilabt.imec.be)
Copy Link

approved this merge request

approved this merge request
lvrossem commented 2023-03-12 12:39:45 +00:00 (Migrated from gitlab.ilabt.imec.be)
Copy Link

unapproved this merge request

unapproved this merge request
lvrossem commented 2023-03-12 12:41:02 +00:00 (Migrated from gitlab.ilabt.imec.be)
Copy Link

The videoplayer for the instructions is just a black screen for me

The videoplayer for the instructions is just a black screen for me
louadria commented 2023-03-12 17:07:55 +00:00 (Migrated from gitlab.ilabt.imec.be)
Copy Link

approved this merge request

approved this merge request
louadria commented 2023-03-12 17:08:28 +00:00 (Migrated from gitlab.ilabt.imec.be)
Copy Link

Looks good to me, don't forget to check the boxes in your description checklist.

Looks good to me, don't forget to check the boxes in your description checklist.
jrcoudro commented 2023-03-12 18:56:47 +00:00 (Migrated from gitlab.ilabt.imec.be)
Copy Link

marked the checklist item I have filled in this template. as completed

marked the checklist item **I have filled in this template.** as completed
jrcoudro commented 2023-03-12 18:56:48 +00:00 (Migrated from gitlab.ilabt.imec.be)
Copy Link

marked the checklist item I have tested my changes thoroughly. as completed

marked the checklist item **I have tested my changes thoroughly.** as completed
jrcoudro commented 2023-03-12 18:56:49 +00:00 (Migrated from gitlab.ilabt.imec.be)
Copy Link

marked the checklist item I have updated the user documentation as necessary. as completed

marked the checklist item **I have updated the user documentation as necessary.** as completed
jrcoudro commented 2023-03-12 18:56:51 +00:00 (Migrated from gitlab.ilabt.imec.be)
Copy Link

marked the checklist item Code reviewed by 2 people. as completed

marked the checklist item **Code reviewed by 2 people.** as completed
jeldgees commented 2023-03-12 19:06:58 +00:00 (Migrated from gitlab.ilabt.imec.be)
Copy Link

marked this merge request as draft

marked this merge request as **draft**
louadria commented 2023-03-16 21:20:52 +00:00 (Migrated from gitlab.ilabt.imec.be)
Copy Link

Since the relevant code here has been used in WES-90, this MR can be deleted.

Since the relevant code here has been used in WES-90, this MR can be deleted.

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
enhancement
impact::high
impact::low
impact::minor
impact::moderate
impact::very low
probability::high
probability::low
probability::minor
probability::moderate
probability::very low
progress::busy
progress::done
progress::review
progress::todo
version::0.1
version::0.2
version::0.3
version::0.4
version::0.5
version::1.0
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
VictorMylle
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: WeSign/unity-application#31
Delete Branch "WES-50-Course-Aspect-Fix"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?