WeSign/unity-application
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 6 Wiki Activity

Draft: Sprint 2 #37

Closed
jeldgees wants to merge 11 commits from development into main
pull from: development
merge into: WeSign:main
Conversation 16 Commits 11 Files Changed 147 +1049 -7592
jeldgees commented 2023-03-12 20:27:00 +00:00 (Migrated from gitlab.ilabt.imec.be)
Copy Link

Description

Please provide a brief summary of the changes in this merge request.

If possible, add a short screengrab or some screenshots of the changes.

Testing Instructions

Please provide instructions on how the code reviewers can test your changes:

  1. Open the app and check if all previous commits are still working

Please include any specific information on test data, configurations, or other requirements that are necessary to properly test the changes.

Once you've tested the changes, please confirm that they work as expected and that there are no regressions or unexpected side effects. If any issues are discovered during testing, please include detailed steps to reproduce the issue in the merge request comments. Thank you!

Related Issues

Please list any related issues or pull requests that are relevant to this merge request.
E.g. WES-XXX-...

Known bugs or issues

Please list any known bugs or issues related to the changes in this merge request.

Checklist

  • I have filled in this template.
  • I have tested my changes thoroughly.
  • I have added appropriate unit tests.
  • I have updated the user documentation as necessary.
  • Code reviewed by 2 people.

Additional Notes

Please add any additional notes or comments that may be helpful for reviewers to understand your changes.

## Description Please provide a brief summary of the changes in this merge request. If possible, add a short screengrab or some screenshots of the changes. ## Testing Instructions Please provide instructions on how the code reviewers can test your changes: 1. Open the app and check if all previous commits are still working Please include any specific information on test data, configurations, or other requirements that are necessary to properly test the changes. Once you've tested the changes, please confirm that they work as expected and that there are no regressions or unexpected side effects. If any issues are discovered during testing, please include detailed steps to reproduce the issue in the merge request comments. Thank you! ## Related Issues Please list any related issues or pull requests that are relevant to this merge request. E.g. WES-XXX-... ## Known bugs or issues Please list any known bugs or issues related to the changes in this merge request. ## Checklist - [x] I have filled in this template. - [ ] I have tested my changes thoroughly. - [ ] I have added appropriate unit tests. - [ ] I have updated the user documentation as necessary. - [ ] Code reviewed by 2 people. ## Additional Notes Please add any additional notes or comments that may be helpful for reviewers to understand your changes.
jeldgees commented 2023-03-12 20:27:00 +00:00 (Migrated from gitlab.ilabt.imec.be)
Copy Link

requested review from @dvschuyl, @hvbreuge, @jrcoudro, @louadria, @lvrossem, and @tihabils

requested review from @dvschuyl, @hvbreuge, @jrcoudro, @louadria, @lvrossem, and @tihabils
jeldgees commented 2023-03-12 20:27:00 +00:00 (Migrated from gitlab.ilabt.imec.be)
Copy Link

assigned to @jeldgees

assigned to @jeldgees
jeldgees commented 2023-03-12 20:27:22 +00:00 (Migrated from gitlab.ilabt.imec.be)
Copy Link

changed title from Draft: {-Development-} to Draft: {+Sprint 2+}

changed title from **Draft: {-Development-}** to **Draft: {+Sprint 2+}**
jeldgees commented 2023-03-12 20:34:23 +00:00 (Migrated from gitlab.ilabt.imec.be)
Copy Link

added 2 commits

  • b11eeb46 - Wes xx mediapipe integration
  • 1d1d11ed - Merge branch 'WES-XX-Mediapipe-integration' into 'development'

Compare with previous version

added 2 commits <ul><li>b11eeb46 - Wes xx mediapipe integration</li><li>1d1d11ed - Merge branch &#39;WES-XX-Mediapipe-integration&#39; into &#39;development&#39;</li></ul> [Compare with previous version](/wesign/unity-application/-/merge_requests/37/diffs?diff_id=30220&start_sha=8349b5f149efe10f96db7a958e46ae2d100fa062)
jeldgees commented 2023-03-12 21:15:53 +00:00 (Migrated from gitlab.ilabt.imec.be)
Copy Link

added 2 commits

  • aa7f7bc7 - WES-51-fingerspelling-result-view
  • 0ac2a166 - Merge branch 'WES-51-fingerspelling-result-view' into 'development'

Compare with previous version

added 2 commits <ul><li>aa7f7bc7 - WES-51-fingerspelling-result-view</li><li>0ac2a166 - Merge branch &#39;WES-51-fingerspelling-result-view&#39; into &#39;development&#39;</li></ul> [Compare with previous version](/wesign/unity-application/-/merge_requests/37/diffs?diff_id=30229&start_sha=1d1d11ed1a209fc36c484c5358bd67cc6fc28324)
vimylle commented 2023-03-12 21:17:02 +00:00 (Migrated from gitlab.ilabt.imec.be)
Copy Link

added 1 commit

Compare with previous version

added 1 commit <ul><li>d07bcf29 - Update .drone.yml</li></ul> [Compare with previous version](/wesign/unity-application/-/merge_requests/37/diffs?diff_id=30231&start_sha=0ac2a1667cb3cb378a2be36ae286f14f864da6c2)
louadria commented 2023-03-12 21:36:37 +00:00 (Migrated from gitlab.ilabt.imec.be)
Copy Link

added 1 commit

Compare with previous version

added 1 commit <ul><li>0812f603 - Fixed build</li></ul> [Compare with previous version](/wesign/unity-application/-/merge_requests/37/diffs?diff_id=30233&start_sha=d07bcf29ca8eed740a66ee553f3748d832eca739)
vimylle commented 2023-03-12 21:44:55 +00:00 (Migrated from gitlab.ilabt.imec.be)
Copy Link

added 1 commit

Compare with previous version

added 1 commit <ul><li>6b445d85 - Add build files [skip ci]</li></ul> [Compare with previous version](/wesign/unity-application/-/merge_requests/37/diffs?diff_id=30235&start_sha=0812f603af8701b94df89d8e56df9a077fe1a1b5)
vimylle commented 2023-03-12 21:51:53 +00:00 (Migrated from gitlab.ilabt.imec.be)
Copy Link

added 1 commit

Compare with previous version

added 1 commit <ul><li>17abca46 - Update .drone.yml</li></ul> [Compare with previous version](/wesign/unity-application/-/merge_requests/37/diffs?diff_id=30238&start_sha=6b445d858c7d072fc79dcda614c500610a1a0e7a)
vimylle commented 2023-03-12 22:03:45 +00:00 (Migrated from gitlab.ilabt.imec.be)
Copy Link

added 1 commit

Compare with previous version

added 1 commit <ul><li>cef72508 - Update .drone.yml</li></ul> [Compare with previous version](/wesign/unity-application/-/merge_requests/37/diffs?diff_id=30240&start_sha=17abca46ea72696a395b3c842df23d92b9542abf)
dvschuyl commented 2023-03-12 22:11:41 +00:00 (Migrated from gitlab.ilabt.imec.be)
Copy Link

added 2 commits

  • 8501edb0 - Add builds
  • 0c795b09 - Merge branch 'development' of gitlab.ilabt.imec.be:wesign/unity-application into development

Compare with previous version

added 2 commits <ul><li>8501edb0 - Add builds</li><li>0c795b09 - Merge branch &#39;development&#39; of gitlab.ilabt.imec.be:wesign/unity-application into development</li></ul> [Compare with previous version](/wesign/unity-application/-/merge_requests/37/diffs?diff_id=30244&start_sha=cef72508cc0e8a19fa1cc76fdff11d0a305a0ffe)
dvschuyl commented 2023-03-12 22:15:40 +00:00 (Migrated from gitlab.ilabt.imec.be)
Copy Link

added 1 commit

Compare with previous version

added 1 commit <ul><li>94ec7e03 - Change directories</li></ul> [Compare with previous version](/wesign/unity-application/-/merge_requests/37/diffs?diff_id=30247&start_sha=0c795b09bc7da1cd13f35189a3d914a92546bfa1)
lvrossem commented 2023-03-13 21:49:48 +00:00 (Migrated from gitlab.ilabt.imec.be)
Copy Link

added 2 commits

  • a267301a - Resolve WES-76 "87 themeselection"
  • 59d69f74 - Merge branch 'WES-76-87-themeselection' into 'development'

Compare with previous version

added 2 commits <ul><li>a267301a - Resolve WES-76 &quot;87 themeselection&quot;</li><li>59d69f74 - Merge branch &#39;WES-76-87-themeselection&#39; into &#39;development&#39;</li></ul> [Compare with previous version](/wesign/unity-application/-/merge_requests/37/diffs?diff_id=30392&start_sha=94ec7e03590d65cbc4b7d937865e20bf9fc33937)
dvschuyl commented 2023-03-14 10:56:47 +00:00 (Migrated from gitlab.ilabt.imec.be)
Copy Link

added 2 commits

  • dfc69ddd - Resolve WES-99 "Cc refactor"
  • 96fb3c89 - Merge branch 'WES-99-cc-refactor' into 'development'

Compare with previous version

added 2 commits <ul><li>dfc69ddd - Resolve WES-99 &quot;Cc refactor&quot;</li><li>96fb3c89 - Merge branch &#39;WES-99-cc-refactor&#39; into &#39;development&#39;</li></ul> [Compare with previous version](/wesign/unity-application/-/merge_requests/37/diffs?diff_id=30485&start_sha=59d69f7412fb82feb587b91b491c871dd7d9e140)
dvschuyl commented 2023-03-16 12:36:52 +00:00 (Migrated from gitlab.ilabt.imec.be)
Copy Link

added 2 commits

  • f6e6afe3 - Resolve WES-113 "Write tests"
  • 5e26970b - Merge branch 'WES-113-write-tests' into 'development'

Compare with previous version

added 2 commits <ul><li>f6e6afe3 - Resolve WES-113 &quot;Write tests&quot;</li><li>5e26970b - Merge branch &#39;WES-113-write-tests&#39; into &#39;development&#39;</li></ul> [Compare with previous version](/wesign/unity-application/-/merge_requests/37/diffs?diff_id=30944&start_sha=96fb3c89c3faa374d69fd2303ae74508a416b424)
louadria commented 2023-03-16 21:28:18 +00:00 (Migrated from gitlab.ilabt.imec.be)
Copy Link

I see sprint 2 has already been merged (as should be!), so this MR is now obsolete.

I see sprint 2 has already been merged (as should be!), so this MR is now obsolete.

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
enhancement
impact::high
impact::low
impact::minor
impact::moderate
impact::very low
probability::high
probability::low
probability::minor
probability::moderate
probability::very low
progress::busy
progress::done
progress::review
progress::todo
version::0.1
version::0.2
version::0.3
version::0.4
version::0.5
version::1.0
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
VictorMylle
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: WeSign/unity-application#37
Delete Branch "development"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?