WeSign/unity-application
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 6 Wiki Activity

Draft: Resolve WES-75 "V3 hangman" #50

Closed
jrcoudro wants to merge 0 commits from WES-75-V3-Hangman into development
pull from: WES-75-V3-Hangman
merge into: WeSign:development
Conversation 2 Commits - Files Changed -
jrcoudro commented 2023-03-19 17:48:48 +00:00 (Migrated from gitlab.ilabt.imec.be)
Copy Link

Description

Added Hangman to the application, without model integration.
Added infopage integration for hangman.
Added scoreboard for Hangman.
Added multiplayer for Hangman.

Testing Instructions

Please provide instructions on how the code reviewers can test your changes:

  1. Create new user
  2. Travel to Hangman via minigames
  3. Try out singleplayer and see if everything works okay
  4. Try out multiplayer and see if everything works okay

Related Issues

WES-81 Works on minigames as well

Known bugs or issues

Spellingbee does not seem to "remember" the minigameindex if it has been initialised to be 1 (Hangman), the reverse is not a problem however.

Hangman still uses the old scoreboard, this will be changed in later integration.

Hangman does not have tests yet.

Checklist

  • I have filled in this template.
  • I have tested my changes thoroughly (both in the editor + build and run (ctrl+B)!).
  • I have added appropriate unit tests.
  • I have updated the user documentation as necessary.
  • Code reviewed by 2 people.

Closes WES-75

## Description Added Hangman to the application, without model integration. Added infopage integration for hangman. Added scoreboard for Hangman. Added multiplayer for Hangman. ## Testing Instructions _Please provide instructions on how the code reviewers can test your changes:_ 1. Create new user 2. Travel to Hangman via minigames 3. Try out singleplayer and see if everything works okay 4. Try out multiplayer and see if everything works okay ## Related Issues WES-81 Works on minigames as well ## Known bugs or issues Spellingbee does not seem to "remember" the minigameindex if it has been initialised to be 1 (Hangman), the reverse is not a problem however. Hangman still uses the old scoreboard, this will be changed in later integration. Hangman does not have tests yet. ## Checklist - [x] I have filled in this template. - [x] I have tested my changes thoroughly (both in the editor + **build and run (ctrl+B)**!). - [ ] I have added appropriate unit tests. - [x] I have updated the user documentation as necessary. - [ ] Code reviewed by 2 people. Closes WES-75
jrcoudro commented 2023-03-19 17:48:48 +00:00 (Migrated from gitlab.ilabt.imec.be)
Copy Link

requested review from @dvschuyl, @hvbreuge, @jeldgees, @louadria, @lvrossem, and @tihabils

requested review from @dvschuyl, @hvbreuge, @jeldgees, @louadria, @lvrossem, and @tihabils
jrcoudro commented 2023-03-19 17:57:58 +00:00 (Migrated from gitlab.ilabt.imec.be)
Copy Link

added 1 commit

  • f4e0a977 - Update Assets/SpellingBee/Scripts/GameEndedPanel.cs

Compare with previous version

added 1 commit <ul><li>f4e0a977 - Update Assets/SpellingBee/Scripts/GameEndedPanel.cs</li></ul> [Compare with previous version](/wesign/unity-application/-/merge_requests/50/diffs?diff_id=31378&start_sha=d722574163276e130423b3174865aef8a45e1fe1)

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
enhancement
impact::high
impact::low
impact::minor
impact::moderate
impact::very low
probability::high
probability::low
probability::minor
probability::moderate
probability::very low
progress::busy
progress::done
progress::review
progress::todo
version::0.1
version::0.2
version::0.3
version::0.4
version::0.5
version::1.0
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
VictorMylle
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: WeSign/unity-application#50
Delete Branch "WES-75-V3-Hangman"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?